a very good list, but a few modifications:
hero: yes, but also 'sub.' not the others though ('hoagie' is specific to philadelphia).
on line: this is frequently mentioned as a marker of new york speech but you'll hear 'in the line' just as often. "shut up and get in the line."
coffee:
nobody calls it "joe".
30 Rock: is a bit precious. using it indicates that you're hip and may know somebody who knows tina fey. just say "30 rockefeller center."
BK: very recent and purely hipster. it's 'bklyn.' BX is, and always has been, the bronx.
fugeddaboudit: still a common and quite useful expression. one meaning is "that question you just asked requires no answer."
vinny: "hey sal, this guy trump, is he a dik?"
sal: "is trump a dik?? fugeddaboudit."
i think the writer is on the young side...
ps, i live on east 84th street. not on 5th though, i can guarantee