It is all great for the Trump campaign. He's encouraged people to have fights with protestors, they did so, which was clearly going to wind people up enough to have larger numbers around and thus larger fights. It all reinforces the idea of persecution etc as well as satisfying and encouraging violent tendencies, in the vast majority by proxy. And because it's by proxy it's just as effective regardless of who "wins" a fight; most Trump supporters will come nowhere near these rallies, and most at the rallies will come nowhere near a protest, and most who are near a protest will not have a fight, and tbh even the ones who do have a fight are unlikely to be so intimidated they give up.
If it's good for something, it's reinforcing the anti-Trump side: showing that there is widespread support (enough that there are multiple protests) and that other people are prepared to risk their safety for it. That's great but it reinforces the Trump support as well.